Re: Sozi integration

[Hans Breuer <hans breuer org>]

Am 18.01.2015 um 22:36 schrieb Paul Chavent:
[...]
> > OK, but the stuff within defined(SOZI_PATH) should be revisited for
> > three reasons: 1) if all external files would be missing there will
> > be four message_error()
> Not sure. The loop breaks upon first failure.
You are right, I've should have read more than the patch.

> > 2) the external_sozi array is sized wrong, best leave out the size
> Thanks, fixed.
> > 3) the hardcoded SOZI_PATH wont work with free installation path
> I've tested with the configure option "--with-sozi-path=" pointing to a
>  path that contains the sozi player files (sozi.version sozi.js
> sozi_extras_media.js and sozi.css). It works as expected. However, i've
> changed the messages to be more concise in case of failure.
This is not what I meant. A fixed path at compile time is only working on 
Unix. For Windows and OS X the user can install the packages is a directory 
of his choice. Plug-in and configutation placement is deduced at runtime 
from relative paths, see e.g. usage of dia_get_data_directory().

> I've pushed the changes :
> https://gitorious.org/dia_sozi/dia_sozi/commit/75054ca492e854b4744dbecb21a8b667a3253f35
Pushed to master.

Thanks,
        Hans

-------- Hans "at" Breuer "dot" Org -----------
Tell me what you need, and I'll tell you how to
get along without it.                -- Dilbert