Re: Sozi integration



Hi.

On 01/16/2015 11:33 PM, Hans Breuer wrote:
Am 15.01.2015 um 23:44 schrieb Paul Chavent:
On 01/14/2015 09:40 PM, Hans Breuer wrote:
[...]
Please reconsider the importance of the message first. IMHO dumping
random stuff to the console is almost never a good idea.
The message should be less verbose now.

OK, but the stuff within defined(SOZI_PATH) should be revisited for three reasons:
  1) if all external files would be missing there will be
     four message_error()
Not sure. The loop breaks upon first failure.
  2) the external_sozi array is sized wrong, best leave out the size
Thanks, fixed.
  3) the hardcoded SOZI_PATH wont work with free installation path
I've tested with the configure option "--with-sozi-path=" pointing to a path that contains the sozi player 
files (sozi.version sozi.js sozi_extras_media.js and sozi.css).
It works as expected. However, i've changed the messages to be more concise in case of failure.

I've pushed the changes : 
https://gitorious.org/dia_sozi/dia_sozi/commit/75054ca492e854b4744dbecb21a8b667a3253f35

Regards

Paul



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]