Re: Sozi integration

[Hans Breuer <hans breuer org>]

Hi Paul,
Am 10.01.2015 um 00:09 schrieb Paul Chavent:
> On 01/08/2015 11:24 PM, Hans Breuer wrote:
>> Am 05.01.2015 um 15:47 schrieb Paul Chavent:
> > > [...]
> > > The media allows to insert video/audio in a presentation. I haven't
> > > extensively tested this object yet.
> > Me neither. If it does not work out the single "Sozi - Frame" might need
> > to get moved back to the Misc sheet?
> Indeed, the initial design (one "Sozi - Frame" on the Misc sheet) was simpler.
>
> Then, I had the choice between :
>   - add an option in the "Sozi - Frame" to behave like a media object
>   - add a new object "Sozi - Media" to clearly separate the two
> functionalities.
> I feel better with the second choice.
Fine with me, if ...
> The current solution is far from being perfect, but the media frame is a
> feature i would like to use in the future.
... that future is going to happen before the next release (whenever that 
comes;)). I'm just a bit reluctant to add source code labeled "untested" 
and "future use" ;-)

> I join a patch that should fix a bug and you can find an integration of a
> video in your example here :
> http://paul.chavent.free.fr/sozi/render-test-sozi.svg (frame 12)
Interesting. But how do I interact with the video when all clicks are 
consumed by the sozi player?

> If you think that the media frame will never be used, i can revert the
> design and move the "Sozi - Frame" in the Misc sheet.
> However i would like to test this feature in the meantime. I only have a
> problem with the url of the video when it is a relative path and that the
> presentation is pushed on a server (it works on a local filesystem).
Maybe you should use dia_relativize_filename() like 
objects/standard/image.c and lib/diasvgrenderer.c ?

> Please tell me if you prefer to totally ignore the media frame.
I'm fine with it in the first version. We can postpone the decision until 
shortly before the next release.

> > So far I've only found minor issues, so this basically looks
> > ready to push to master.
> >
> > Issues found so far:
> >    - sozi-frame copy does not copy properties like text color
> I will fix this issue.
Maybe just an object_copy_props() in the copy methods is missing?

> >    - apparently bounding box calculation is not completely correct
> >      with rotation (try to "rubber-band" selecting sozi-frame #6)
> I don't understand how to "rubber-band" and how to reproduce what you mean.
> >    - with sozi-frame
> ?
To select sozi-frame #6 in the file it is not possile to simply click on 
it, because that frame is completly covered by #12 and #7. To select #6 on 
the canvas click outside of all objects on the canvas, left to #6 and drag 
the "rubber-band" until it completley includes #6, but no other object on 
that layer. When releasing the mouse button #6 should get selected.
If it does not either the rectangle was too small to cover the whole 
bounding box or the bounding box was miscalculated. I assume the later.

[...]
> >   - automatic sequence number generation [4]
> >     => Same as before, but should be acceptable for the first
> >        version included.
> Yes i prefer to help the user to maintain the sequence consistent. About
> the fact that the update is done after, selecting other frames, i would
> like to improve this but i don't know how. Perhaps you could suggest me how
> to redraw an object (see
> https://gitorious.org/dia_sozi/dia_sozi/source/23d6d55818b3754bb345a74e89e94fe00ed2ac52:objects/Sozi/sozi-frame.c#L200)
> ?
A call to object_add_updates() would trigger the redraw, but it's not 
allowed to do that from outside of app/

Thinking some more about this:
 - what's upposed to happen with the sequence numbers after undo?

> > Did I miss something?
>
> I will submit a new version when i will be sure to keep the media as is or
> not.
As I said I'm fine with pushing what we currently have. It is probably more 
simple to improve from that common base. Any objections?

> Thank you very much for your review.
Thanks for your contribution to Dia.

        Hans

-------- Hans "at" Breuer "dot" Org -----------
Tell me what you need, and I'll tell you how to
get along without it.                -- Dilbert