Re: Drag & Drop - Follow-up Patch

["Andreas J. Guelzow" <aguelzow math concordia ab ca>]

On Wed, 2002-09-25 at 19:12, Lutz Müller wrote:
> On Thu, 2002-09-26 at 00:43, Andreas J. Guelzow wrote:
> > I agree. But do we need the dialog when the user has manually adjusted
> > the order in the dialog _and_ the workbook?
>
> No. But I don't think killing the dialog when the user changes something
> with the sheets (order, adding, deleting) is a good idea...

I did not suggest killing the dialog. Perhaps the dialog ought to
remember that there were certain changes and check for conflicts (?)
when the user clicks okay and only then bring up a dialog.
> Attached a patch that will enable me to make the dialog aware of things
> like sheet addition and deletion. Please apply.

No patch...  :-(

> I've got the corresponding patches to dialogs/dialog-sheet-order.c on my
> machine, but things don't quite work yet. One reason for that is that
> the signal sheet_order_changed will get emitted if you add or delete a
> sheet. I don't think this is a good idea. It would make things more easy
> if you only emit that signal if sheets were really reordered.

What does it mean "really reordered" when the number of sheets changes?
Does inserting a new sheet `reorder' the existing ones?  

Andreas