Re: Drag & Drop - Follow-up Patch

This code does not work properly: I get various

** (gnumeric:2135): CRITICAL **: file dialog-sheet-order.c: line 720
(dialog_sheet_order_update_sheet_order): assertion `n_sheets ==
n_children' failed

for example:

bring up the sheet manage dialog and add 2 sheets, okay, click `yes' on
the first question dialog... CRITICAL

if I add the missing call to post_sheet_index_change:
bring up the sheet manage dialog and add a sheet then reorder sheets by
dragging in the original window... CRITICAL

The main issue is that the list of sheets in the dialog reflect the
desired list, not the current list of sheets. I would think that that
list should not be adjusted on every drag and drop!


On Tue, 2002-09-24 at 21:45, Jody Goldberg wrote:
On Wed, Sep 25, 2002 at 12:08:07AM +0200, Lutz M?ller wrote:
On Tue, 2002-09-24 at 20:12, Jody Goldberg wrote:
1) I'm not thrilled with when the sheet_order_changed signal is
fired please put it in post_sheet_index_change.
Done. But this function doesn't get called if you reorder the sheets
using drag & drop.

It should.
We depend on that to handle 3d dependencies.  Andreas will you have
time to see why that is not being called ?

2) hmm, removing the arrow when you're not on a label significantly
reduces its utility.  Can you rework it to function anywhere within
the control's toplevel window ?

Patch attached.
Looks good.  That behavior works nicely.

There is a lifecycle problem such that after reordering thing crash
on exit.  I'll have a look shortly.
gnumeric-list mailing list
gnumeric-list gnome org

Attachment: signature.asc
Description: This is a digitally signed message part

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]