Re: [xml] Windows threading issues

On Fri, Jul 11, 2003 at 12:49:24PM +0200, Igor Zlatkovic wrote:
Daniel Veillard wrote:
       xmlSchemaValidateDoc        (xmlSchemaValidCtxtPtr ctxt,
                               xmlDocPtr instance);

So I take it you prefer them to be on their own lines and not together on 
one line with the return type?

   all on the same line will make alignment of arguments harder, no ?

Nono, only the macros and the return type go to the same line, like this:

         xmlSchemaValidateDoc        (xmlSchemaValidCtxtPtr ctxt,
                                      xmlDocPtr instance);

  that's fine too :-)

The function name and the argument list remain untouched. This is similar to 
what is happening now. When a function name + return type are too long for 
argument alignment, the two appear on the separate lines, like in the 
following example from xpathInternals.h:

         xmlXPathNewParserContext    (const xmlChar *str,
                                      xmlXPathContextPtr ctxt);

After the modification, all functions will look like that, with those macros 
surrounding the return type. I think it's easier on eyes than spreading all 
of it across multiple lines.



Daniel Veillard      | Red Hat Network
veillard redhat com  | libxml GNOME XML XSLT toolkit | Rpmfind RPM search engine

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]