Re: [gnome-flashback] Gnome Flashback
- From: Philipp Kaluza <floss ghostroute eu>
- To: gnome-flashback-list gnome org
- Subject: Re: [gnome-flashback] Gnome Flashback
- Date: Wed, 28 May 2014 00:54:14 +0200
Am 28.05.2014 00:44, schrieb Alberts Muktupāvels:
Not sure why you didn't use my merge-commit (88c6cfb) nor why you lost
the "features/" prefix (which I think is a good convention), but overall
it looks much better, thanks. Will look at the branch in more detail in
a few days.
I wanted to go thru all process for learning purpose.
Cool, fair enough. Creating a branch with slashes is as easy as:
git checkout -b features/$FEATURENAME $STARTPOINT
...
git push origin features/$FEATURENAME
Also, because I had just pointed Lanoxx towards it and it bears repeating:
"read https://wiki.gnome.org/Git and related pages, especially the
Tips+Tricks and the FAQ."
and:
"When doing work on patches in general, please try to keep the links
between mailing list discussions, bugzilla discussions, and the git
commit message intact; this goes doubly for feature branches. We are a
bit bad about this at the moment, and I'd like us to do better. "
By "keep the links intact" I of course mean "explicitly put links that
describe the connection", like a "Closes:
https://bugzilla.gnome.org/..." or "As discussed in
https://mailgnome.org/..." in a commit message.
Cheers
Philipp
--
Philipp Kaluza
Ghostroute IT Consulting
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]