Re: [PATCH] Multi-VC chooser preferences

[Vincent Legoll <vincent legoll gmail com>]

On Tue, Mar 10, 2009 at 12:31 AM, Stephen Kennedy <stevek gnome org> wrote:
> This is a great feature.

Thanks, the diffstat is very nice too:

$ svn diff | diffstat
 glade2/vcview.glade |   15 +++++++++++++++
 historyentry.py     |   11 +++--------
 vc/__init__.py      |   16 +++-------------
 vcview.py           |   46 +++++++++++++++++++++++-----------------------
 4 files changed, 44 insertions(+), 44 deletions(-)

Talk about cheap features... :-)

> This patch works for me too, except for the same warnings as Vincent.
> I see google has plenty of hits, but I didn't get to the root cause.

Maybe we should ask on pygtk or gtk devel MLs...

> One minor nitpick about the spacing - shouldn't the browse... button be a
> little closer to the entry since they're related and unrelated to the combo?

Maybe this is related to the hidden button_jump, I'll check this.

-- 
Vincent Legoll