Re: [PATCH] Multi-VC chooser preferences

[Kai Willadsen <kai willadsen gmail com>]

2009/3/5 Vincent Legoll <vincent legoll gmail com>:
> Hello,
> here is a first step in the hopefully right direction.
>
> A combobox is added at the left side of the location
> text entry & button.
>
> But I have a hard time giving that combobox the same
> size as the text entry and the button...
>
> The problem is far more visible on my gentoo desktop
> than on the ubuntu notebook, but could be better.
>
> Tell me what you think of this one.

Not sure whether it would be unnecessary visual clutter, but there's
also the option of leaving it visible the whole time, mostly on a
UI-shouldn't-change basis. I have no real opinion on this... just
thought I'd throw it out there.

This button should probably just be defined in the glade file, rather
than manually added. Also, I'd guess that the combobox's model should
just be cleared out, rather than replacing the whole widget.

+_plugins_map = dict([(pl.Vc.NAME.upper(), pl) for pl in _plugins])

Why use .upper()? It's not like we should have to resolve a conflict
between plugins called git, Git and GiT... I hope.

Kai