Re: [PATCH] Multi-VC chooser preferences

[Vincent Legoll <vincent legoll gmail com>]

On Fri, Mar 6, 2009 at 7:50 PM, Kai Willadsen <kai willadsen gmail com> wrote:
> 2009/3/5 Vincent Legoll <vincent legoll gmail com>:
> Not sure whether it would be unnecessary visual clutter, but there's
> also the option of leaving it visible the whole time, mostly on a
> UI-shouldn't-change basis. I have no real opinion on this... just
> thought I'd throw it out there.

Yes maybe, that would allow meld to show the information of which
Vc it has detected in the directory, and disabling the combobox when
it only has one entry to additionally tell the user that there's only one
in that directory...

Stephen, what do you think of that idea ?

> This button should probably just be defined in the glade file, rather
> than manually added. Also, I'd guess that the combobox's model
> should just be cleared out, rather than replacing the whole widget.

I tried that, but found the code more complex than just recreating
a new combobox each time, which is a rare operation anyways...

> +_plugins_map = dict([(pl.Vc.NAME.upper(), pl) for pl in _plugins])
>
> Why use .upper()? It's not like we should have to resolve a conflict
> between plugins called git, Git and GiT... I hope.

This code is leftover from when it was used in another way, thanks
for spotting, I'll need to clean that up before submitting...

Thanks for the review, I'm currently testing your suggestion, looks
doable, and maybe not too ugly...

-- 
Vincent Legoll