Re: [PATCH] Multi-VC chooser preferences

[Kai Willadsen <kai willadsen gmail com>]

2009/3/7 Vincent Legoll <vincent legoll gmail com>:
>> This button should probably just be defined in the glade file, rather
>> than manually added. Also, I'd guess that the combobox's model
>> should just be cleared out, rather than replacing the whole widget.
>
> I tried that, but found the code more complex than just recreating
> a new combobox each time, which is a rare operation anyways...

Ah right. I forgot that the text-based combobox API doesn't have a
ListStore.clear() equivalent. However, something like this should
work:

    for i in range(len(self.combobox_vcs.get_model())):
        self.combobox_vcs.remove_text(0)

...or did you mean that other parts of the code became more
complicated? Anyway, really not a big deal either way.

> Thanks for the review, I'm currently testing your suggestion, looks
> doable, and maybe not too ugly...

It was just a vague suggestion; I don't actually know whether it's a
good idea or not. If it turns out to be ugly, then I'd ignore me...

Kai