Re: [Gimp-developer] the Gimp lcms.c plug-in

[Michael Natterer <mitch gimp org>]

On Tue, 2012-07-24 at 17:37 -0400, Elle Stone wrote:
> Perhaps what I really should be asking is what is the process by which
> an existing patch to the Gimp code is applied so that everyone can use
> it?

Your way of doing patches *and* actively communicating is the only
way that will guarantee your patches to land. We are short on
resources, and naturally active community members are harder to
forget, as opposed to patches sitting in bugzilla.

So please, just go ahead, look at the patches in bugzilla, pick the
best stuff from your patches and the bugzilla ones, and all will be
fine.

> In particular, by what process does Gimp get patched to use lcms2? ( I
> kinda doubt that the Gimp developers are going to let Elle Stone patch
> Gimp, as the chances are very great that Elle Stone would break Gimp
> in the process.)

Breaking gimp at least once is part of the initiation ceremony,
don't worry ;)

> I don't need to patch my own copy of Gimp. It's already using lcms2.
> 
> On 7/24/12, Michael Schumacher <schumaml gmx de> wrote:
> > On 24.07.2012 23:16, Elle Stone wrote:
> >
> >> How does one apply a patch? What does "apply a patch" mean?
> >
> > You use the patch program to apply the changes that are contained in the
> > attachments to the bug report to the GIMP code.
> >
> > The usage example from the Wikipedia article about patch should do:
> > http://en.wikipedia.org/wiki/Patch_%28Unix%29
> >
> > patch < foo.diff
> >
> > This could be executed in the top directory of your GIMP source tree.
> >
> > There are parameters to adjust for differences in the diff files
> > regarding both your and the patch author's systems, see
> > http://linux.die.net/man/1/patch - -p is the most commonly used
> > parameter to get rid of leading folders in the paths used in the diff
> > file, for example.
> >
> >
> > --
> > HTH,
> > Michael
> > _______________________________________________
> > gimp-developer-list mailing list
> > gimp-developer-list gnome org
> > https://mail.gnome.org/mailman/listinfo/gimp-developer-list
> >
> 
>