Re: [evolution-patches] Bug 127812: Make Evolution use the gnome-icon-theme (all modules)



On Thu, 2004-01-08 at 09:18, Jeffrey Stedfast wrote:
> icon_list = e_icon_factory_get_icon_list ("stock_mail-compose");
> (seems odd that they mix _ and -)

Yeah, I'm not sure the rational, but all 'stock' icons in
gnome-icon-theme have a prefix of 'stock_' and use - everywhere else.


> shouldn't that be using a #define'd macro name rather than a literal
> string? I know that Gtk (and GNOME?) do stuff like:
> 
> #define GTK_STOCK_MAIL_COMPOSE  "stock-mail-compose"
> 
> I would prefer you used the #define name

Ah.  The GTK+ stock icons are different from these stock icons.  These
icons don't have any #define's.  The string is just the filename of the
file in the gnome-icon-theme module minus the extension.

-mt

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]