Re: [evolution-patches] Bug 127812: Make Evolution use the gnome-icon-theme (all modules)

[JP Rosevear <jpr ximian com>]

On Wed, 2003-12-24 at 19:59, Michael Terry wrote:
> This patch is a proposed fix for bug 127812.  It expands the role of
> e-icon-factory from being a helper class in shell to being the
> authoritative source for all icons inside Evolution.

What is the reasoning behind you moving it?  Also it would probably be
better to include <e-util/e-icon-factory.h> instead of fiddling with the
includes so e-util is directly in the include path.

> It uses GnomeIconTheme to pull requested icons.  It affects all modules
> that use icons (most of them).  This patch might change some of the
> icons visibly -- in particular with the Tools->Settings... dialog.  If
> an icon cannot be found, a blank placeholder icon is used instead, so
> even though several of the icons are not present in gnome-icon-theme
> (see bug 129294), Evolution is still usable.

Maybe Jakub can comment on availability.  Basically we can't ship with
out all the icons in place (although as many as possible should be
used).

> The only unconverted section of Evolution is conduits.  To do so
> requires a change in gnome-pilot, and I've filed a bug to deal with that
> (bug 129958).  I feel that this is not a big deal though, and maybe
> shouldn't hold up the committing of this patch.

I think this is fine.

-JP
-- 
JP Rosevear <jpr ximian com>
Ximian, Inc.