On Wed, 2004-01-07 at 18:04, JP Rosevear wrote: > On Wed, 2003-12-24 at 19:59, Michael Terry wrote: > > This patch is a proposed fix for bug 127812. It expands the role of > > e-icon-factory from being a helper class in shell to being the > > authoritative source for all icons inside Evolution. > > What is the reasoning behind you moving it? Also it would probably be > better to include <e-util/e-icon-factory.h> instead of fiddling with the > includes so e-util is directly in the include path. OK to the e-util/e-icon-factory.h include change. I will submit a revised patch with it. As for the move, I would like to prefix my reasoning saying that I am not very familiar with the Evolution CVS layout. The main reason for the move was that both the widgets and e-util directories needed to use e_icon_factory, and if it was in shell, the build order was wrong. I couldn't figure out an easier solution to fixing this. Especially since it seemed to my mind that e-util was a more logical spot for it (seems more of a utility than a function of the Evolution main shell?). I would gladly accept advice on how to fix the build order problem while leaving e_icon_factory in shell. -mt
Attachment:
signature.asc
Description: This is a digitally signed message part