Re: [evolution-patches] Bug 127812: Make Evolution use the gnome-icon-theme (all modules)

[Jeffrey Stedfast <fejj ximian com>]

another thing.... I don't understand the logic with the int1 and int2
thing here. What's the deal with that?

Jeff

 GtkWidget *e_create_image_widget(gchar *name,
                                 gchar *string1, gchar *string2,
                                 gint int1, gint int2)
 {
-       char *filename;
        GtkWidget *alignment = NULL;
        if (string1) {
                GtkWidget *w;
+               GdkPixbuf *pixbuf;
+
+               pixbuf = e_icon_factory_get_icon (string1, 48);
+
+               w = gtk_image_new_from_pixbuf (pixbuf);
+               g_object_unref (pixbuf);
 
-               if (*string1 == '/')
-                       filename = g_strdup(string1);
-               else
-                       filename = g_build_filename (EVOLUTION_IMAGES,
string1, NULL);
+               gtk_misc_set_alignment (GTK_MISC (w), 0.5, 0.5);
 
-               w = gtk_image_new_from_file (filename);
+               if (int1)
+                       int1 = 1;
+               if (int2)
+                       int2 = 1;

On Thu, 2004-01-08 at 01:06, Michael Terry wrote:
> On Wed, 2004-01-07 at 18:18, Michael Terry wrote:
> > On Wed, 2004-01-07 at 18:04, JP Rosevear wrote:
> > > On Wed, 2003-12-24 at 19:59, Michael Terry wrote:
> > > > This patch is a proposed fix for bug 127812.  It expands the role of
> > > > e-icon-factory from being a helper class in shell to being the
> > > > authoritative source for all icons inside Evolution.
> > > 
> > > What is the reasoning behind you moving it?  Also it would probably be
> > > better to include <e-util/e-icon-factory.h> instead of fiddling with the
> > > includes so e-util is directly in the include path.
> > 
> > OK to the e-util/e-icon-factory.h include change.  I will submit a
> > revised patch with it.
> 
> Attached is my revised patch.  I also fixed a couple typos.  You still
> need my e-icon-factory.{c,h} from my first mailing.
> 
> Please provide feedback about the meat and potatoes of the patch as
> well.
> 
> -mt
-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com