Re: [evolution-patches] Bug 127812: Make Evolution use the gnome-icon-theme (all modules)

[Jeffrey Stedfast <fejj ximian com>]

icon_list = e_icon_factory_get_icon_list ("stock_mail-compose");
(seems odd that they mix _ and -)

shouldn't that be using a #define'd macro name rather than a literal
string? I know that Gtk (and GNOME?) do stuff like:

#define GTK_STOCK_MAIL_COMPOSE  "stock-mail-compose"

I would prefer you used the #define name

Jeff

On Thu, 2004-01-08 at 01:06, Michael Terry wrote:
> On Wed, 2004-01-07 at 18:18, Michael Terry wrote:
> > On Wed, 2004-01-07 at 18:04, JP Rosevear wrote:
> > > On Wed, 2003-12-24 at 19:59, Michael Terry wrote:
> > > > This patch is a proposed fix for bug 127812.  It expands the role of
> > > > e-icon-factory from being a helper class in shell to being the
> > > > authoritative source for all icons inside Evolution.
> > > 
> > > What is the reasoning behind you moving it?  Also it would probably be
> > > better to include <e-util/e-icon-factory.h> instead of fiddling with the
> > > includes so e-util is directly in the include path.
> > 
> > OK to the e-util/e-icon-factory.h include change.  I will submit a
> > revised patch with it.
> 
> Attached is my revised patch.  I also fixed a couple typos.  You still
> need my e-icon-factory.{c,h} from my first mailing.
> 
> Please provide feedback about the meat and potatoes of the patch as
> well.
> 
> -mt
-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com