Re: --show-layers=... alternative

[Simon Kagstrom <simon kagstrom bth se>]

On 2005-04-03, 21:59, Hans Breuer wrote:
> > http://bugzilla.gnome.org/show_bug.cgi?id=172507
> Some nitpicking:
>
> - you are using strtok_r() to split the string into pieces. That function
>   is neither portable nor utf8 aware (if that matters). It would be better
>   to use g_strsplit()
> - please don't use strdup() and free() but their g_* equivalent. The latter
>   are guaranteed to not return on failure.
> - g_error() will also call exit(). IMO g_assert() would be more appropriate
>   at some places

I now use g_strsplit and g_strfreev for parsing the commas, I've changed some
of the errors into g_asserts (_parse_numbers should only be called with a
valid number, all else is an error) and one g_error into a warning-printout
(specifying e.g. --show-layers=6-2, when no layers will be shown).

> > I'm afraid I uploaded an incorrect version first, sorry for that. I also
> > didn't touch the ChangeLog or the manual, but I can do that if I'm 
> > supposed to
> > do it :-)
> That would be nice.

I've updated the ChangeLog, but am a bit unsure about the documentation. There
is a man-page in doc/dia.1, but there is a note about it being auto-generated
on top. I cannot find the source of it though, or is the man-page actually
supposed to be changed?

I'll send the patch tonight.

// Simon