Re: --show-layers=... alternative

[Lars Clausen <lars raeder dk>]

On Sun, 2005-04-03 at 15:51 +0200, Simon Kagstrom wrote:
> On 2005-04-03, 11:07, Simon Kagstrom wrote:
> > Hello Dia-developers!
> >
> > I implemented a patch for Dia yesterday against the Debian/Sarge dia package
> > source (attached in the mail). This patch implements a command-line option to
> > specify which layers to show on exports.
>
> I updated the patch for the CVS version of Dia and attached it here. It
> implements --show-layers-range and works as outlined in the last mail.
>
> One thing which I didn't like is that with one more command-line argument,
> do_convert and a few other functions are starting to get may arguments. Maybe
> it's better to define a struct with all arguments and pass that to the
> functions that need the arguments instead? In the patch, I just added another
> argument.

I see the use of the functionality (I never thought Dia would be used
for animation!), but agree that another command-line argument is bad.
We could do a slight hack and say that if the argument to
--export-layers is in [0-9,-] then it's layer numbers, otherwise it's
layer names.  If somebody names all their layers just numbers, they
might get confused, and we could emit a warning if a layer name is just
digits and dashes.

-Lars

-- 
Lars Clausen <lars raeder dk>