Re: Pull request template for github mirror

On Fri, Feb 26, 2016 at 09:25:57PM -0500, Hubert Figuire wrote:
On 26/02/16 06:30 PM, Alberto Ruiz wrote:

I do know it is not ideal to have unattended contributions, mind though,
GitHub won't allow an option for disabling Pull Requests even though we
asked for it. And I committed to not allow usage of PRs since we don't want
to rely on a closed service for our operations.

I think someone should poke the maintainers of each module, have them
make a decision and eventually get the PR closed (either by taking,
rejecting or redirecting the contribution).

Very few people have permissions to close these request (there are 4
members in the "GNOME" github project AFAI). I think we should add
people that are okay with it. I'm fine helping with that - ie getting
write access. My user name on github is "hfiguiere"

I am mystified and pleasantly surprised: there was a fine pull-request
against the dasher project on github. I still don't know how you can
discover the individual commits that make up a pull-request. Today
I merged the github fork which presumably contained all of the commits
in the pull-request and more. I pushed to git.gnome, and magically the
pull-request on github got closed(!) How is this all meant to work?



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]