Re: Pull request template for github mirror

[Alberto Ruiz <aruiz gnome org>]

Perhaps I should jump in as I created the mirror alongside Andrea Veri.

The mirror in general is quite useful, a lot of people fork projects and check them out automatically instead of checking them out from git.gnome.org and then pushing them in github. These contributions (there's about 200 pull requests, see link below) would likely not have happened if we didn't have a presence in Github. Shutting down the mirror would simply stop that energy.

https://github.com/search?utf8=%E2%9C%93&q=type%3Apull+user%3Agnome+state%3Aopen

I do know it is not ideal to have unattended contributions, mind though, GitHub won't allow an option for disabling Pull Requests even though we asked for it. And I committed to not allow usage of PRs since we don't want to rely on a closed service for our operations.

As per Thomas suggestion I think it's an overkill to modify every single repo. The real solution is to finish this script/hook that would find the right bugzilla product URL in the .doap file and create a bug in bugzilla automatically for the user. If we were able to then allow logins from github's OAuth into our bugzilla instance that'd be great as it would reduce friction.

Anyhow, Thomas, I got stuck with the OAuth aspect of this script:
https://gist.github.com/aruiz/4583b78e1d56f79f083d

If you really want to help, I would suggest I give you access to the API keys and finish it. How does that sound?

2016-02-26 23:10 GMT+00:00 Lasse Schuirmann <lasse schuirmann gmail com>:

Is there any advantage of having those mirrors after all? Nobody really seems to care and I'm against adding a folder to trick a proprietary tool into not hurting us. It's read only anyway...

(I have not followed all previous discussions regarding this though.)

On 27 Feb 2016 12:02 a.m., "Jehan Pagès" <jehan marmottard gmail com> wrote:

Hello,

Speaking as one of the GIMP developers (which does not mean I speak on
behalf of the GIMP project here, but in my name). I certainly don't
want us to start using github, and actually would not care if we
stopped using it to mirror our repository. As you say yourself, this
is very confusing and probably a lot of people would think that all
these GNOME projects are actually hosted there as upstream, since
nothing tells otherwise by looking at the github page!

BUT if we really have to continue mirror the repos there, I would
personally say that we may as well do it well and add such a file, if
that is all it takes to stop people from creating pull requests.
Isn't there more simply a way to just forbid pull requests? I see we
already don't use the bug tracker nor the wiki. Isn't it possible to
do the same for the pull request UI?

Also another thing I was wondering is: who has the rights to close the
pull requests? On the GIMP project for instance, we have 4 pull
requests: https://github.com/GNOME/gimp/pulls
I have (exceptionnally) pushed one of the commits separately, some
time ago, another is not valid anymore, and the last 2 have also been
made on the bugtracker by this contributor since then. Could someone
with rights on the Github GNOME account close these 4 pull requests?
Thanks.

Jehan


On Fri, Feb 26, 2016 at 11:16 PM, Thomas H.P. Andersen <phomes gmail com> wrote:
> Hi maintainers,
>
> We have mirrors of git set up at github.com/gnome. Apparently developers are
> mistaking these mirrors as upstream and send pull requests there. Unless the
> maintainers actively keeps an eye on it these pull requests will go
> unnoticed.
>
> One way to deal with this is to add a pull request template to github
> telling the user that this is not the correct place for submitting patches
> and a link to the relevant bugzilla page.
>
> The way to add a pull request template is by creating a file
> .github/PULL_REQUEST_TEMPLATE in the repository. As the repos on github are
> just mirrors such a file would have to go into upstream git.
>
> I volunteer to create template files for all our mirrored repositories if
> there is interest. I understand that adding these files upstream may be
> controversial, but I think that being visible on github is helpful to new
> developers, and this could be a way to avoid those lost patches.
>
> Tell me what you think.
>
> - Thomas
>
> _______________________________________________
> desktop-devel-list mailing list
> desktop-devel-list gnome org
> https://mail.gnome.org/mailman/listinfo/desktop-devel-list
_______________________________________________
desktop-devel-list mailing list
desktop-devel-list gnome org
https://mail.gnome.org/mailman/listinfo/desktop-devel-list

_______________________________________________
desktop-devel-list mailing list
desktop-devel-list gnome org
https://mail.gnome.org/mailman/listinfo/desktop-devel-list

--

Cheers,
Alberto Ruiz