Re: Google Contacts Problem





On Sat, Sep 6, 2008 at 4:50 PM, Fabio Rafael da Rosa <fabiorafael rosa gmail com> wrote:
I'll check on that.
Hold the patch, I'll going to fix the Instant Messenger piece of code,
then we can submit the full patch

That sounds sensible. Much appreciated

John
 


Em Sáb, 2008-09-06 às 08:06 +0200, John Stowers escreveu:
>
>
> 2008/9/5 Fabio Rafael da Rosa <fabiorafael rosa gmail com>
>         I'm running your latest patch, and everything is working.
>         I get another patch on the list, for the phone numbers, and
>         made some
>         fixes for that to work properly.
>         I tested using folder and evolution contacts, and it's working
>         properly.
>         I'll try to fix the Instant Messenger piece of code when I
>         have more
>         time. Please check this patch and make your comments.
>         It has your previous patches on it. If it's a problem, let me
>         know and I
>         make another patch
>         Thanks
>
>
> This looks good. Can you please change the suffix stuff as I suggested
> in my last email.
>
>
> Basically instead of what you are doing at the moment, set the new
> filename in the converter.
>
>
>      def contact_to_file(self, contact, **kwargs):
>          #get vcard data
>          f = Utils.new_tempfile(contact.get_vcard_string())
>          f.force_new_file_extension('.vcf')
>          return f
>
>
> Jc2k, can you apply this patch when these changes are made?
>
>
> John
>
>
>
>         Regards
>
>         Em Qui, 2008-09-04 às 16:12 +0100, John Carr escreveu:
>
>
>         > On Thu, Sep 4, 2008 at 3:57 PM, Fabio Rafael da Rosa
>         > <fabiorafael rosa gmail com> wrote:
>         > > Sorry for the delay, I was without internet connection
>         (work problems).
>         > > I tried your patch and it didn't work.
>         > > I made some changes and got it to work better, but it
>         still is not 100%
>         > > I had some problems at work this week, so I didn't have
>         much time to
>         > > check on that. Problably I'll be able to take a look
>         tonigh and I hope I
>         > > can finish that :) .
>         > > I'll add you second patch to my changes and let you
>         know :).
>         > >
>         > > Thanks
>         > >
>         > > Regards
>         >
>         > Can you try the third patch? It combines the first 2 and
>         fixes some
>         > stupid errors...
>         >
>         > John
>
>
>         _______________________________________________
>         Conduit-list mailing list
>         Conduit-list gnome org
>         http://mail.gnome.org/mailman/listinfo/conduit-list
>
>
>
--
Fabio Rafael da Rosa <fabiorafael rosa gmail com>




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]