Re: Icon list replaced by treeview and message/rfc822 attachments

[Miquel van Smoorenburg <miquels cistron nl>]

On 2003.06.04 04:32, Peter Bloomfield wrote:
> Just committed to cvs:
> - use the message font for the source viewer;
> - add a View menu with the option to turn off escaping of the text.

Wow, excellent.

Minor nit: it doesn't compile:

source-viewer.c: In function `libbalsa_show_file':
source-viewer.c:131: warning: implicit declaration of function `libbalsa_utf8_sanitize'
source-viewer.c:131: `LibBalsaCodeset' undeclared (first use in this function)
source-viewer.c:131: (Each undeclared identifier is reported only once
source-viewer.c:131: for each function it appears in.)
source-viewer.c:131: syntax error before numeric constant
make[2]: *** [source-viewer.o] Error 1
make[2]: Leaving directory `/home/staff/miquels/cvs/balsa/libbalsa'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/staff/miquels/cvs/balsa'
make: *** [all-recursive-am] Error 2

I added #include "misc.h" to source-viewer.c and it compiled.

Also, in libbalsa/rfc3156.c this doesn't look right to me:

#ifdef BALSA_USE_THREADS
#  include <pthread.h>
#  include "misc.h"
#endif

Why only include misc.h when using threads? Esp. when misc.h has the
same #ifdef BALSA_USE_THREADS include <pthread.h> stuff.

Mike.
-- 
... somehow I have a feeling the hurting hasn't even begun yet
	-- Bill, "The Terrible Thunderlizards"