Re: [anjuta-devel] Vala and the new code-assistance architecture

[Abderrahim Kitouni <a kitouni gmail com>]

Hi Moritz,

                  في ر، 20-06-2012 عند 22:57 +0200 ، كتب Moritz Lüdecke:
> Hi,
>
> > GETTEXT_PACKAGE is defined using the command line so it's probably 
> > just
> > some Makefile magic to do but am sure Abderrahim will know how to do
> > that in Vala.
> >
> > You probably only have to extend config.vapi though, see
> > https://live.gnome.org/Vala/GameDevelopmentSeries/Setup (Section
> > "Config.vapi")
> Thanks. The setting widget port is now complete: 
> https://github.com/ritze/anjuta-clang/commit/84c3957222cadcd1bf7bdf0bdfc84b905bc12ef6

Good, you should probably prepare a patch for inclusion into master.

btw, there are still some C-isms in your code, for example:

GLib.Signal.connect (toggle, "toggled",
                     (GLib.Callback) on_autocompletion_toggled, toggle);

should be simply:

toggle.toggled.connect (on_autocompletion_toggled);

Another thing I noticed:
var toggle = (Widget) bxml.get_object (PREF_WIDGET_AUTO);
...
on_autocompletion_toggled ((ToggleButton) toggle);

could (or rather should) be just:

var toggle = (ToggleButton) bxml.get_object (PREF_WIDGET_AUTO);
on_autocompletion_toggled (toggle);

btw, I prefer to use checked casts:

var toggle = bxml.get_object (PREF_WIDGET_AUTO) as ToggleButton;

I find it cleaner.

Thanks,
Abderrahim