Re: Patch for the MaemoConic device
- From: Sergio Villar Senin <svillar igalia com>
- To: tinymail-devel-list <tinymail-devel-list gnome org>
- Subject: Re: Patch for the MaemoConic device
- Date: Fri, 04 Apr 2008 13:35:03 +0200
Chris Lord escribiu:
> As I have no idea of the context in which this is called, I may just be
> terribly wrong, but this doesn't look right to me - As signal handler
> ids may be reused (unlikely but possible), they should really be
> assigned to zero by the signal handler callback before it finishes, and
> this check should be a check for != 0 (and is_connected if you want to
> be extra-safe) and should disconnect and set the signal id variable to
> zero.
Well, the signal handler callback is called many times, so it shouldn't
set the handler id to 0. Maybe I don't get your point.
Br
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]