Re: Patch for the MaemoConic device

[Philip Van Hoof <spam pvanhoof be>]

On Fri, 2008-04-04 at 12:20 +0100, Chris Lord wrote:
> As I have no idea of the context in which this is called, I may just be
> terribly wrong, but this doesn't look right to me - As signal handler
> ids may be reused (unlikely but possible), they should really be
> assigned to zero by the signal handler callback before it finishes, and
> this check should be a check for != 0 (and is_connected if you want to
> be extra-safe) and should disconnect and set the signal id variable to
> zero.
> 
> At least, that's how I see it anyway.

If this is the case, can you add that to your fix, sergio?

Thanks for your review, Chris.


-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be