Re: Patch for the MaemoConic device

As I have no idea of the context in which this is called, I may just be
terribly wrong, but this doesn't look right to me - As signal handler
ids may be reused (unlikely but possible), they should really be
assigned to zero by the signal handler callback before it finishes, and
this check should be a check for != 0 (and is_connected if you want to
be extra-safe) and should disconnect and set the signal id variable to

At least, that's how I see it anyway.


On Fri, 2008-04-04 at 10:50 +0200, Sergio Villar Senin wrote:
> This patch properly disconnects the "connection-event" signal in the
> Maemo Conic device. We're trying to disconnect this signal from the
> TnyDevice instead of from the Conic connection. I think this could be
> the source of lots of SIGSEV's we're seeing when finalizing.
> Br
> _______________________________________________
> tinymail-devel-list mailing list
> tinymail-devel-list gnome org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]