Re: Tab support as experimental feature in 1.3.4 ?

Andrea Vettorello said:     (by the date of Tue, 5 Aug 2008 09:48:25 +0200)

> > Please don't hesitate to comment on this idea.
> I haven't looked at the code so I can be way off, but as tabs are
> theme dependents, could it be activated only when one choose a tabs
> enabled theme?

yes, exactly. Maybe it wasn't clear, because I've sent multiple
emails answering to myself (too much to read - sorry).

Scott will need to add a theme tab-capability checking. And if the
user decides to enable checkbox with experimental feature, he will be
informed if the theme is not tab-capable. As you said - the checkbox
can be grayed out if wrong theme is chosen. Or a dialog window could
appear, or sth else.

> Last time I've looked themes were treated with caution (IIRC "gaoled"
> was the term used, at the end it's code that we are downloading and
> running from untrusted sources) so probably doing it inside themes is
> not feasible.

Tab code in sawfish will check themes tab-capability. Perhaps by
checking if some variables are defined and not nil. We don't want to
modify hundreds of already existing themes just to say that they
don't have tab support.

Alternatively (simplest solution perhaps) - a short list of themes
with tab support can be hardcoded inside sawfish. And sawfish will
recognize them by name. Such solution is not a long-term one, so it
will be changed in the future. But this feature is experimental, and
the current goal is to allow people to do some preliminary testing
and feedback.

best regards
Janek Kozicki                                                         |

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]