Re: [Rhythmbox-devel] music sharing patch #2

[Christophe Fergeau <teuf gnome org>]

Le mercredi 10 août 2005 à 11:06 -0400, Colin Walters a écrit :
> On Wed, 2005-08-10 at 17:02 +0200, Christophe Fergeau wrote:
> > Le mercredi 10 août 2005 à 10:50 -0400, Colin Walters a écrit :
> > 
> > > So unless there's a technical reason why we need the configure option
> > > and #ifdefs, let's just remove them.  We should probably be moving in
> > > the direction of killing other configure switches like bonobo/dbus, cd
> > > burning, etc too.
> > 
> > dbus and cd burning configure switches are there because both depend (or
> > used to depend) on bleeding edge libraries, or on libraries with
> > unstable apis, and it made it easier for testers to just disable the
> > feature if the necessary packages aren't there. 
> 
> But doesn't Rhythmbox unconditionally need the very latest GTK+ and
> totem for example?  If you're a developer/tester you should be using
> jhbuild which should handle this stuff for you, right?

Once upon a time (at the beginning of 2.11 development cycle), rhythmbox
could be made to work with gnome 2.10 if the cd burning was disabled.
Then there were issues with dbus, rhythmbox used an older version of the
api, and jhbuild used the newer api, which also caused some pain.
If those issues are now sorted out, and if rb needs most of gnome 2.11
anyway, I don't care if the #ifdef are removed. 

Christophe