Re: [Rhythmbox-devel] music sharing patch #2

On Mon, 2005-08-08 at 20:20 -0400, Charles Schmidt wrote:

> The patch is /everything/ against CVS (not split into 'core' & 'daap'
> parts like last time), mostly because I don't have the time to split it
> and test the patches - I'm going out of town tonight and won't be back
> til next Sunday.  I felt it'd be good to get this out there and get some
> feedback as it is.

Actually I was thinking about this a bit more and my earlier suggestion
of plugins was totally backwards, basically a bad programmer reflex :) 
Why wouldn't we just want music sharing to always be enabled and
integrated?  That way other parts of the code can be aware of it more
easily; for example, if you were to delete a playlist that someone else
was using, we might want a dialog like "This playlist is being used by N
other users; really delete? [No] [Screw Them]".  Or in the case of your
patch, keeping the hardcoded daap:// stuff in the player instead of
trying to bend over backwards to have the player call back into the
soruce.  Tight integration is harder if functionality is optional.

So unless there's a technical reason why we need the configure option
and #ifdefs, let's just remove them.  We should probably be moving in
the direction of killing other configure switches like bonobo/dbus, cd
burning, etc too.

Attachment: signature.asc
Description: This is a digitally signed message part

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]