Re: [orca-list] Strange speech problem

[Joanmarie Diggs <jdiggs igalia com>]

On 1/14/19 9:56 AM, Samuel Thibault wrote:
> Joanmarie Diggs, le lun. 14 janv. 2019 09:46:11 -0500, a ecrit:
> > > Maybe with a fallback in case keyval_name is empty, but well.  In any
> > > case, it should fix this, and seems more robust than the current guess.
> >
> > The current guess is to trust AT-SPI2.
> >
> > If I change it in Orca, any other tool that presents keystrokes will
> > have to make a similar check. It would be nice if AT-SPI2 could just
> > tell ATs what the label is.
>
> Well, that is exactly what keyval does, it is Enter for the enter key,
> and M for the M key, and keyval_name just makes it a string.

Right, but at the present time Orca is having to do extra work to
calculate the keyval name. In fact, it has a dependency on Gdk for that.
It also has to do this work for apps and toolkits which don't provide an
event string. What I'm suggesting is that AT-SPI2 provide the keyval
name Orca should present. Then all AT-SPI2 clients could benefit from it
and Orca wouldn't have to depend on Gdk (or duplicate that code).

Are you saying that AT-SPI2 shouldn't do this work and that instead all
AT-SPI2 clients should?

--joanie