GNOME.org
 

Re: [orca-list] Feature request: enhance button quick navigation

Hello,


Thanks for the revert.

It's working fine.
I tried to look into it my-self and it turns out I have managed to fix it the way you are planning after returning back home.
I know this is just a minor thing but newertheless I've created a merge request putting your yesterday's commit back adding my two line fix on top of that. 


https://gitlab.gnome.org/GNOME/orca/merge_requests/27
It appears editable content is already special cased in orca because we are only checking the editable state and ignoring roles. 


Greetings


Peter


Dňa 11. 12. 2018 o 10:05 Joanmarie Diggs napísal(a):

Bah. Looks like I really missed it too. I'm traveling today, so I just
reverted the general form field change, leaving the button-related one
in place. So hopefully what's in master still addresses your original
concern. I'll re-look into the other issue when I'm back at work. Please
let me know if you find any other side effects and thank you very much
for your rapid testing and feedback!
--joanie

On 12/11/18 9:23 AM, Peter Vágner wrote:

Hello,


Oh yeah. I have really missed this one.

It appears as navigating to the text entries bound to the letter e and
shift+e fails early. Even no more entries message is not present.


As for the formfields in general this appears to be working fine over
here. Interestingly enough it's also finding text entries. Quick
navigation to form fields is bound to orca+tab and orca+shift+tab. So
unless you have tweaked your configuration f and shift+f won't work.



Greetings


Peter




Dňa 11. 12. 2018 o 9:12 mayson napísal(a):

Hello joanie and all. its mayson. I just spotted a bug in orca master!
Joanie, when you press e or shift e to move to entries or edit
controls in firefox with the latest version of orca master and firefox
orca does not move to edit boxes or pressing f to move orca by form
feelds no longer works please take a look at this asap. thanks joanie
and all! Aloha, Mayson.

On 12/10/18 9:49 PM, Peter Vágner via orca-list wrote:

Hello,


Thank you verry much this feels awesome after a bit of initial testing.

I haven't ran into issues so far.


Greetings


Peter


Dňa 10. 12. 2018 o 16:01 Joanmarie Diggs napísal(a):

I've subsequently made a similar change so that more non-focusable form
fields will be reachable via structural navigation. That won't
magically
make them fully accessible (depending on the widget type and what all
the author has done or failed to do). But it should at least make them
more discoverable. Please let me know if you encounter any unwanted
side
effects as a result of this change.

Thanks again!
--joanie

On 12/10/18 3:41 PM, Joanmarie Diggs wrote:

This should be fixed in master. Please try and let me know. Thanks!
--joanie

On 12/10/18 9:29 AM, Peter Vágner via orca-list wrote:

Hello,

I am seeing this for a long time however finally I have managed to
sit
down and find out precise steps to reproduce.

Environment: Arch linux, GNOME 3.30, GTK 3.22, Firefox nightly,
orca master

Steps:
* Open the sitehttp://www.radio-browser.info/gui/#/  in Firefox
* Press ctrl+home to make sure cursor moves to the top of a page.
* Press the tab key until orca reports FAQ link.
* Now continue navigating the page by repeatedly pressing right arrow
key and notice there are some collabsed toggle buttons there.
* Now press ctrl+home to jump to the top.
* Press letter b to jump to the next button.

Results #1:
Those not focusable toggle buttons are skipped from quick navigation.

Expected case #1:
These toggle buttons should be included in both button quick
navigation
as well as list of buttons.
Note I can make these buttons to become findable by these orca
features
when hacking the corresponding nodes with tabIndex property by using
Firefox web console.
So although this is most likelly an authoring issue rather than orca
issue, we might like orca to become a bit smarter i.e. if the
button is
not disabled we still would like to be able to find it eventhough
it may
not be focusable.
I've patched the angular app in question at:
https://github.com/segler-alex/radiobrowser/pull/136  so on its next
deployment this will be fixed, however I fear something like this
might
be also seen elsewhere in the wild.


I think previously I was unable to find expand all, open in a new
window
and print buttons when navigating opened email conversation in Gmail,
but I can't reproduce this any more.

Thanks and greetings

Peter

_______________________________________________
orca-list mailing list
orca-list gnome org
https://mail.gnome.org/mailman/listinfo/orca-list
Orca wiki:https://wiki.gnome.org/Projects/Orca
Orca documentation:https://help.gnome.org/users/orca/stable/
GNOME Universal Access guide:
https://help.gnome.org/users/gnome-help/stable/a11y.html
Log bugs and feature requests athttp://bugzilla.gnome.org


_______________________________________________
orca-list mailing list
orca-list gnome org
https://mail.gnome.org/mailman/listinfo/orca-list
Orca wiki:https://wiki.gnome.org/Projects/Orca
Orca documentation:https://help.gnome.org/users/orca/stable/
GNOME Universal Access guide:
https://help.gnome.org/users/gnome-help/stable/a11y.html
Log bugs and feature requests athttp://bugzilla.gnome.org


_______________________________________________
orca-list mailing list
orca-list gnome org
https://mail.gnome.org/mailman/listinfo/orca-list
Orca wiki:https://wiki.gnome.org/Projects/Orca
Orca documentation:https://help.gnome.org/users/orca/stable/
GNOME Universal Access guide:
https://help.gnome.org/users/gnome-help/stable/a11y.html
Log bugs and feature requests athttp://bugzilla.gnome.org
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]