Re: [NM-openconnect PATCH] Allow 'lasthost' and 'autoconnect' settings.

[David Woodhouse <dwmw2 infradead org>]

On Wed, 2009-05-13 at 10:11 -0400, Dan Williams wrote:
> On Tue, 2009-05-12 at 20:37 +0100, David Woodhouse wrote:
> > On Tue, 2009-05-12 at 11:10 -0400, Dan Williams wrote:
> > > I'd store most of them with the connection details in GConf, then ignore
> > > them in the vpn service plugin. 
> > 
> > That's what I do. I keep having to add new items to be ignored, and
> > update the vpn service plugin in lock-step with the auth-dialog (which
> > is shipped with openconnect itself). Hence:
> > http://git.gnome.org/cgit/network-manager-openconnect/commit/?id=ba97bd52
> > http://git.gnome.org/cgit/network-manager-openconnect/commit/?id=09071a81
> > 
> > I'm actually tempted to make the vpn service plugin just ignore
> > _anything_ it doesn't understand. There's no benefit in bailing out, is
> > there?
> 
> Sure, however maybe having to jump through this hoop would be a good
> time to ask why you're adding those options in the first place.  Not
> that they aren't useful and required, but maybe a chance to think about
> it again.

Heh. Fair enough. :)

> > >  What is that socket icon next to the
> > > server name?  Is that a "connect now" button?
> > 
> > Yes. It actually connects automatically when you change the selected
> > host in the combobox... but if the one you want is the _default_, and
> > you haven't got "automatically start connecting...' set, then you'll end
> > up hitting the connect button.
> 
> Not really discoverable... why doesn't it have any text?

Because the person who rewrote my original crappy UI implementation
didn't put any text on it :)

-- 
dwmw2