Re: [PATCH] Fix shift-select in manual icon layout mode

[Alexander Larsson <alexl redhat com>]

On Thu, 2005-07-14 at 22:41 +0200, Christian Neumair wrote:
> Am Donnerstag, den 14.07.2005, 10:50 +0200 schrieb Alexander Larsson:
> > On Thu, 2005-07-14 at 10:34 +0200, Christian Neumair wrote:
> > > Am Mittwoch, den 13.07.2005, 14:09 +0200 schrieb Alexander Larsson:
> > > > On Wed, 2005-07-13 at 13:51 +0200, Christian Neumair wrote:
> > > > > Am Mittwoch, den 13.07.2005, 13:45 +0200 schrieb Alexander Larsson:
> > > > > > On Tue, 2005-07-12 at 18:19 +0200, Christian Neumair wrote:
> > > > > > > From bug 150116 [1]:
> > > > > > > 
> > > > > > > "When trying to select a range of files if ordering is set to manual,
> > > > > > > the range of files is determined by file names instead of spatial
> > > > > > > location.
> > > > > > > 
> > > > > > > This is especially obvious on the desktop where there is no auto-sort."
> > > > > > > 
> > > > > > > Proposed patch attached.
> > > > > > > 
> > > > > > > [1] http://bugzilla.gnome.org/show_bug.cgi?id=150116
> > > > > > > 
> > > > > > 
> > > > > > +		x0 = MIN (icon1->x, icon2->x);
> > > > > > +		x1 = MAX (icon1->x, icon2->x);
> > > > > > +		y0 = MIN (icon1->y, icon2->y);
> > > > > > +		y1 = MAX (icon1->y, icon2->y);
> > > > > > 
> > > > > > This doesn't look entierly right. Surely you want the whole part of the
> > > > > > icons, not just its position (which i think is the corner? don't
> > > > > > remember exactly).
> > > > > 
> > > > > Yes, as far as I know it's the upper-left corner. What's wrong with it?
> > > > > You think we should also select items which just "touch"/intersect the
> > > > > range to be selected instead of matching only those that are actually
> > > > > contained within the range?
> > > > 
> > > > consider this case:
> > > > 
> > > >  a 
> > > >   bc
> > > >   
> > > > where b and c really overlap vertically, except c is one pixel above b.
> > > > [...]
> 
> > [...]
> > 
> > In the attached image of my desktop, your range select algorithm doesn't
> > include the middle icon. I'm pretty sure this is not what most people
> > expect.
> 
> The attached patch produces acceptable results at least on my desktop,
> since the vertical grid space is 20 px. 25 px should also be enough to
> handle some additional icon height-related displacement.

Its still extremely weird. It allows 25 pixel above the highest icon,
but only the top 25 pixels of the lowest icon. Just either use the full
extent of both icons to calculate the max/min position, or use the
middle of the icon.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a time-tossed neurotic Green Beret on a mission from God. She's a wealthy 
belly-dancing wrestler with a song in her heart and a spring in her step. They 
fight crime!