Re: [PATCH] Fix shift-select in manual icon layout mode

Am Mittwoch, den 13.07.2005, 13:45 +0200 schrieb Alexander Larsson:
> On Tue, 2005-07-12 at 18:19 +0200, Christian Neumair wrote:
> > From bug 150116 [1]:
> > 
> > "When trying to select a range of files if ordering is set to manual,
> > the range of files is determined by file names instead of spatial
> > location.
> > 
> > This is especially obvious on the desktop where there is no auto-sort."
> > 
> > Proposed patch attached. If you don't like the two separate code-paths
> > mangled into one function (like classic C coders do), we can also split
> > these two loops out into separate functions.
> > 
> > [1]
> > 
> +		x0 = MIN (icon1->x, icon2->x);
> +		x1 = MAX (icon1->x, icon2->x);
> +		y0 = MIN (icon1->y, icon2->y);
> +		y1 = MAX (icon1->y, icon2->y);
> This doesn't look entierly right. Surely you want the whole part of the
> icons, not just its position (which i think is the corner? don't
> remember exactly).

Yes, as far as I know it's the upper-left corner. What's wrong with it?
You think we should also select items which just "touch"/intersect the
range to be selected instead of matching only those that are actually
contained within the range?

> Also, this is sort of a strange range sort. Its more of a rectangle
> selection. Maybe its better than what we have for the manual sort case
> though.

Well, we could do a wrapping selection based on the position of the
items as well, which would also take into account the
NautilusIconLayoutMode. You're the boss.

Christian Neumair <chris gnome-de org>

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]