Re: [PATCH] Fix shift-select in manual icon layout mode

[Alexander Larsson <alexl redhat com>]

On Tue, 2005-07-12 at 18:19 +0200, Christian Neumair wrote:
> From bug 150116 [1]:
> 
> "When trying to select a range of files if ordering is set to manual,
> the range of files is determined by file names instead of spatial
> location.
> 
> This is especially obvious on the desktop where there is no auto-sort."
> 
> Proposed patch attached. If you don't like the two separate code-paths
> mangled into one function (like classic C coders do), we can also split
> these two loops out into separate functions.
> 
> [1] http://bugzilla.gnome.org/show_bug.cgi?id=150116
> 

+		x0 = MIN (icon1->x, icon2->x);
+		x1 = MAX (icon1->x, icon2->x);
+		y0 = MIN (icon1->y, icon2->y);
+		y1 = MAX (icon1->y, icon2->y);

This doesn't look entierly right. Surely you want the whole part of the
icons, not just its position (which i think is the corner? don't
remember exactly).

Also, this is sort of a strange range sort. Its more of a rectangle
selection. Maybe its better than what we have for the manual sort case
though.


=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an old-fashioned day-dreaming waffle chef who dotes on his loving old ma. 
She's a foxy blonde bodyguard from beyond the grave. They fight crime!