Re: [PATCH] Multi-VC chooser preferences

[Vincent Legoll <vincent legoll gmail com>]

On Thu, Mar 5, 2009 at 11:20 PM, Vincent Legoll
<vincent legoll gmail com> wrote:
> On Thu, Mar 5, 2009 at 11:07 PM, Stephen Kennedy <stevek gnome org> wrote:
>> Ah that's super! I think we're on the same page on this one. You've
>> got my vote to commit.
>
> I would like to investigate a small problem first. The patch was working ok
> on my gentoo desktop, but on the laptop it's not displying initial multi VC
> before a refresh is made manually...

The difference was that I didn't test the same thing on the 2 distros.
What was broken was doing "meld ." instead of "meld /path/to/dual/vc"

The bug was, not doing:

location = os.path.abspath(location)

before creating the VC instance out of location, because of reordering
the code to avoid adding a "vc" parameter to set_location()

Can you see other fishy thing by doing it this way ?

I.e. creating the VC before:

def set_location(self, location):
  #### here it is now, sort of... ####
  self.model.clear()
  location = os.path.abspath(location)
  self.fileentry.gtk_entry.set_text(location)
  #### Here it was before ####

-- 
Vincent Legoll