Re: gnome-core 1.4.0.3 available

[Remi Cohen-Scali <Remi Cohen-Scali COM>]

I found the missing statement for updating the icon selection widget. It was simpler. here
is the patch. It is against gnome-icon-entry.c of gnome-libs-1.2.13.

====cut=here====
--- gnome-icon-entry.c.old Tue Oct  5 17:34:12 1999
++ gnome-icon-entry.c Mon May  7 21:56:33 2001
@@ -472,7 +471,10 @@
    gtk_object_get_user_data(GTK_OBJECT(ientry));
   if(!GTK_WIDGET_VISIBLE(ientry->pick_dialog))
    gtk_widget_show(ientry->pick_dialog);
-  if(gis) gnome_icon_selection_show_icons(gis);
+  if(gis) {
+                        gnome_icon_selection_show_icons(gis);
+                        if (curfile) gnome_icon_selection_select_icon(gis, strrchr(curfile,
'/')+1);
+                }
  }
 }

====cut=here====

I am going to test it thoroughly to see if their is no side effects ...

George a écrit :

> On Sun, May 06, 2001 at 04:45:14PM +0200, Remi Cohen-Scali wrote:
> > Actually I have been browsing the code and I realized it was a problem of the dentry
> > widget.
> > It seems the widget do not emit a signal when the file entry one (changed) is received.
> > Is it really what happening ?
> > Thanks for your explanations
>
> OK, the issues are complex.  The standard gnome icon entry does not actually
> have a real changed signal.  By some stroke of dementia we made the entry in
> the browse dialog box theentry the icon entry gets the icon from.  This meant
> that if you bind to the changed signal there, it's very simple to get the icon
> button and the actual icon out of sync.  So what I do is a very ugly hack with
> juggling two icon entries.  What it seems to me is that I'm forgetting to check
> changes on the entry when ok is pressed.
>
> George

--
                                     Remi Cohen-Scali
   _/_/_/   _/    _/  _/      /      Development engineer
   _/      _/    _/  _/_/   _/       International Center for Network Computing
  _/_/_/  _/    _/  _/  _/ _/        Network Service Provider Division
     _/  _/    _/  _/   _/_/         Phone:     +33-139-447-509  x44509
_/_/_/   _/_/_/   _/     _/          E-mails: Remi Cohen-Scali Sun COM
M  I  C  R  O  S  Y  S  T  E  M  S            Remi Cohen-Scali COM
                                     WAPmail: Remi CohenScali Itineris Net