Re: [gnome-db] [PATCH] Fix some memory leaks

["Joel Pfaff" <joel pfaff gmail com>]

On Tue, Mar 18, 2008 at 2:33 PM, Murray Cumming <murrayc murrayc com> wrote:

On Tue, 2008-03-18 at 09:24 -0400, Phil Longstaff wrote:
> Murray Cumming wrote:
> > I am reverting this change:
> > http://svn.gnome.org/viewvc/libgda/branches/release-3-0-branch/libgda/gda-config.c?r1=2902&r2=3078
> >
> > 1. You changed it to return a copy  even though the documentation says
> > "Gets a #GdaProviderInfo structure from the provider list given its
> > name, don't modify or free it."
> >
> > 2. You freed the result of gda_config_get_provider_list() even though
> > its documentation also says that you should not free the result. This
> > caused a crash.
> >
>
> I did not submit that change.

Indeed. Sorry. That was Joel Pfaff.

Indeed, sorry that was me. I did not see that we keep the GdaProviderInfo data in a static pointer. Next call leading to crash (my test case only included one call).

Sorry for the troubles.

--
Joel