Re: [gnome-db] [PATCH] Fix some memory leaks

On Sun, 2008-03-16 at 15:00 -0400, Phil Longstaff wrote:
> Murray Cumming wrote:
> > On Sun, 2008-03-16 at 13:20 -0400, Phil Longstaff wrote:
> >> The attached patch fixes some memory leaks.  In certain cases, the
> >> string returned from g_object_get() or xmlNodeGetContent() was not freed.
> > 
> > Thanks. Is this change meant to be in this patch? It seems unrelated.
> Yes, this is unrelated.  It is a previous patch that I sent in which was
> accidentally included.

That was really a hint to submit a corrected patch, but I have committed
the intended parts now, to both branches. Thanks.

> > In general, it is helpful if you can create an svn patch, also
> > the ChangeLog. And patches are less likely to be forgotten if they are
> > attached to a bugzilla bug.

Murray Cumming
murrayc murrayc com

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]