Re: [gnome-db] [PATCH] Fix some memory leaks
- From: Murray Cumming <murrayc murrayc com>
- To: Phil Longstaff <plongstaff rogers com>
- Cc: gnome-db-list gnome org
- Subject: Re: [gnome-db] [PATCH] Fix some memory leaks
- Date: Tue, 18 Mar 2008 13:24:49 +0100
I am reverting this change:
http://svn.gnome.org/viewvc/libgda/branches/release-3-0-branch/libgda/gda-config.c?r1=2902&r2=3078
1. You changed it to return a copy even though the documentation says
"Gets a #GdaProviderInfo structure from the provider list given its
name, don't modify or free it."
2. You freed the result of gda_config_get_provider_list() even though
its documentation also says that you should not free the result. This
caused a crash.
--
murrayc murrayc com
www.murrayc.com
www.openismus.com
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]
