[Gimp-user] Bug in "arrow" plugin, possible bug with tear-off menus

[programmer_ceds <forums gimpusers com>]

> I had to apply the patch below to make your script run under Gimp 2.9.
> Are these patches OK ?
>
> Thanks,
> Helmut
>
>
> --- arrow.scm.ORIG     2014-09-16 11:21:14.000000000 +0200
> +++ ../arrow.scm       2015-12-11 11:16:30.810268551 +0100
> @@ -119,7 +119,7 @@
> (aset points 2 theLeftWingEndPointX)      (aset points 3
> theLeftWingEndPointY)
> (aset points 4 theMiddleWingEndPointX)    (aset points 5
> theMiddleWingEndPointY)
>              (aset points 6 theRightWingEndPointX) (aset points 7  
> theRightWingEndPointY)
> -            (gimp-free-select image 8 points CHANNEL-OP-REPLACE TRUE
> FALSE 0)
> +            (gimp-image-select-polygon image CHANNEL-OP-REPLACE 8  
> points)
>              (gimp-edit-bucket-fill drawable FG-BUCKET-FILL  
> NORMAL-MODE 100 0 FALSE 0 0)
>              (gimp-selection-none image)
>          ))
> @@ -312,7 +312,7 @@
>
>                               (set! num_points (* num_points 2))
>                               (set! num_points (+ num_points 6))
> -                              (gimp-free-select image num_points  
> in_fill_points CHANNEL-OP-REPLACE TRUE FALSE 0)
> +                              (gimp-image-select-polygon image  
> CHANNEL-OP-REPLACE num_points in_fill_points)
>                               (gimp-edit-bucket-fill drawable  
> FG-BUCKET-FILL NORMAL-MODE 100 0 FALSE 0 0)
>                               (gimp-selection-none image)
>                       )       ; end -begin
> @@ -450,7 +450,7 @@
>                                                            (car  
> (gimp-image-height    image))
> (+ 1 (* 2
> (car (gimp-image-base-type image))))
> "Arrow"
> 100
> NORMAL-MODE )))
> -                (gimp-image-add-layer image drawable 0)
> +                (gimp-image-insert-layer image drawable 0 0)
>                  ; set new layer completely transparent
>                  (gimp-layer-add-mask drawable (car  
> (gimp-layer-create-mask drawable ADD-BLACK-MASK)))
>                  (gimp-layer-remove-mask drawable MASK-APPLY)

Hi  Mark,

I modified the script last night to correct the drawing of arrow heads at the
end of paths with more than two points. I also included the suggestion about
only using positive numbers.

I still have to tidy the changes a bit and I will do this later and update the
zip file then.

Hi Helmut

I had been wondering whether the scripts that I have written would still work on
V2.9/2.10, thanks for providing the patches. To make life easier for me (I use
Windows) is it possible that you could post the complete version of the script
as you have edited it (or provide a link so that I can download it) - I can then
use a file comparison program to compare it with the original unedited version
and incorporate the differences into my newly modified version - this should be
easiest way of transferring the changes without introducing errors
(alternatively is there a simple unified diff inclusion program for W7?). If the
changes required for V2.9 mean that the script will not work under V2.8 I will
add conditional code so that it will function under either version.

-- 
programmer_ceds (via www.gimpusers.com/forums)