Re: Custom headers RFE WAS: Re: [Evolution] RFE: ability to add headers to "standard" display.

On Mon, 2002-04-22 at 18:24, Ian Goldberg wrote:
On Mon, 2002-04-22 at 20:27, Jeffrey Stedfast wrote:
it will severely increase the complexity of the display code, and it's
already nasty enough as it is without adding to it.

The complexity of the display code?  Sure, the *UI* part usually adds a
lot of code, but this is the only change to the display part:

diff -u -r1.219 mail-format.c
--- mail/mail-format.c        2002/01/21 21:58:07     1.219
+++ mail/mail-format.c        2002/01/26 14:59:05


And pretty much all of that logic is cut/paste from a paragraph or two
earlier in the code (so it could probably be factored out).  There's
just a GSList of strings corresponding to which extra headers to display
in the "Normal Display" (the patch lets you create this list using a UI
widget in "Mail Settings" -> "Display").  Then after it writes all the
default headers in the normal way, it iterates through the header list
in the message, and if the header matches one of the selected headers in
the GSList, it displays that one, too.  It's a linear search, but I
assume you're not listing thousands of extra headers to display.

I was actually hoping that my idea of "show custom headers" would become
the default way of thinking of and displaying headers, with an internal
list of "normal" headers, which would be the defaults in the dialog box
I mentioned before.  A "show all headers" would short-circuit the "Show
all headers" value to be ".*", and the custom headers would actually
read and apply the variables.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]