Re: [PATCH] Highlight color for bright text.

[Hans Breuer <hans breuer org>]

At 16.04.2012 07:17, Paul Chavent wrote:
> Hi.
>
> I've posted a patch some weeks ago. I'm surprised to had no reactions. So,
> i would like to take a second chance.
>
> I sometimes draw coloured squares (eg blue) with bright text inside (eg
> white).
>
> When i select this text, i can't see it because the highlight is yellow.
>
> So i would like to suggest this patch and have your opinion.
If you want also feedback from the user perspective it might help to 
describe the desired effect rather than just giving an uncommented patch.

If I understood your code right it will change the highlighting color to 
black if the luminance value of the text color is higher than 72%.

> This patch still have a problem : it doesn't change the cursor color... but
> it's more a patch for opening the discussion than a definitive solution.
At least I am ambivalent if we should replace the one single hard-coded 
color with just two hard-coded colors. A better idea might be to derive 
both these colors from the theme as discussed in
https://bugzilla.gnome.org/show_bug.cgi?id=599447#c3

BTW: any news on your "sozi" feature?
[ https://mail.gnome.org/archives/dia-list/2011-November/msg00031.html ]

Thanks,
        Hans

-------- Hans "at" Breuer "dot" Org -----------
Tell me what you need, and I'll tell you how to
get along without it.                -- Dilbert