Re: [PATCH] Highlight color for bright text.

At 16.04.2012 07:17, Paul Chavent wrote:

I've posted a patch some weeks ago. I'm surprised to had no reactions. So,
i would like to take a second chance.

I sometimes draw coloured squares (eg blue) with bright text inside (eg

When i select this text, i can't see it because the highlight is yellow.

So i would like to suggest this patch and have your opinion.

If you want also feedback from the user perspective it might help to describe the desired effect rather than just giving an uncommented patch.

If I understood your code right it will change the highlighting color to black if the luminance value of the text color is higher than 72%.

This patch still have a problem : it doesn't change the cursor color... but
it's more a patch for opening the discussion than a definitive solution.

At least I am ambivalent if we should replace the one single hard-coded color with just two hard-coded colors. A better idea might be to derive both these colors from the theme as discussed in

BTW: any news on your "sozi" feature?
[ ]


-------- Hans "at" Breuer "dot" Org -----------
Tell me what you need, and I'll tell you how to
get along without it.                -- Dilbert

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]