Re: [PATCH] Highlight color for bright text.

Le 04/24/2012 10:32 PM, Hans Breuer a écrit :
At 16.04.2012 07:17, Paul Chavent wrote:

I've posted a patch some weeks ago. I'm surprised to had no reactions. So,
i would like to take a second chance.

I sometimes draw coloured squares (eg blue) with bright text inside (eg

When i select this text, i can't see it because the highlight is yellow.

So i would like to suggest this patch and have your opinion.

If you want also feedback from the user perspective it might help to describe the desired effect rather than 
just giving an uncommented patch.

If I understood your code right it will change the highlighting color to black if the luminance value of the 
text color is higher than 72%.

The desired effect is to see the selected text, regardless its color.

This patch still have a problem : it doesn't change the cursor color... but
it's more a patch for opening the discussion than a definitive solution.

At least I am ambivalent if we should replace the one single hard-coded color with just two hard-coded 
colors. A better idea might be to derive both these colors from the theme as discussed in

Do you mean the "desktop" theme ? I'm not sure that it has any effect on this problem...

I remember having used a software that change the selected text color with a kind of "negative" effect 
(something like that

BTW: any news on your "sozi" feature?
[ ]

I'm curently use it "as is". I haven't done many improvments...


Thanks for your reply.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]