Re: Clickable URL's again... new patch

[Albrecht Dreß <albrecht dress arcormail de>]

Am 13.06.2001 17:20:55 schrieb(en) Ali Akcaagac:
> just detected this...
> 
> there is the possibility to go to links like this
> 
> http://xx.xx.xx.xx/index.html#prolog
> 
> and your url handler cuts the edge before #
> 
> here a specific example
> 
> http://www.squarefree.com/bookmarklets/pagelinks.html#open_selected_links
> 
> needs to be reviewed maybe.

Ooops. A bug in the regexp, I forgot the "#". Sorry!!! The correct one reads
(line 1147 in src/balsa-message.c):

static const gchar *url_str = "((((https?|ftps?|gopher|telnet|nntp)://)|(mailto:|news:))(%[0-9A-Fa-f]{2}|[-!#$&'()*+,./0-9:;=?@A-Z_a-z~])+)([).!';/?:,][[:blank:]])?";

Maybe it is safe to rely on the right oder of ascii chars on every machine?
Then we could simplify (well, not really ;-)) this a little bit:

static const gchar *url_str = "((((https?|ftps?|gopher|telnet|nntp)://)|(mailto:|news:))(%[0-9A-Fa-f]{2}|[!#$&-;=?-Z_a-z~])+)([).!';/?:,][[:blank:]])?";

I agree fully with Brian that we should not make this regexp user definable (I
also see tons of messages in this list, regarding bad regexps...).

Albrecht.


-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    Albrecht Dreß  -  Monschauer Straße 22  -  D-53121 Bonn (Germany)
      Phone (+49) 228 6199571  -  E-Mail albrecht.dress@arcormail.de
_________________________________________________________________________