Re: 2 borkage detected

["M . Thielker" <balsa t-data com>]

On 2001.08.18 19:02 Ali Akcaagac wrote:
> > In the course of that move, a header X-Balsa-Original-Mailbox-URI: will
> be
> > added to the message, containing the URL of the mailbox the message was
> > deleted from.
> 
> is this RFC conform ? does RFC allow such things to be added ? i am no
> GURU of these things.

AFAIK anyone can add any desired header to a message as long as it's:
a) prefixed by X-
b) follows the general format of message headers so other applications will
not choke trying to parse it

> well i dont understand everything here but as long as its reasonable i am
> all for it. but its necessary to keep an eye of the whole code, since
> something
> i really hate is 'remaining dead sourcecode' as it is now, look at the
> first
> mail in this thread, the ifclause for showing the trashicon has no real
> usage
> because someone changed the code before.
> 
> conclusion:
> 
> - make the codepiece usable
> - remove it completely

The code is usable, and there's support for it in libbalsa. It's just not
currently used, but since there is support for it, other apps that may use
the lib, or future versions of Balsa, may set the deleted flag on a message.
If that happens, the trashcan will be properly shown by those 2 lines of
code. That's the intention and I don't think it's necessary or desirable to
remove a working piece of code that may need to be added again later. It
correctly handles a feature present on lower layers and even though that
feature is not used now, it can't hurt to have a handler in place.

Melanie