Re: [anjuta-devel] Change project property interface

[Abderrahim Kitouni <a kitouni gmail com>]

Hello all,

              في ح، 18-12-2011 عند 11:46 +0100 ، كتب Sébastien Granjoux:
> Hi,
>
> Le 18/12/2011 03:20, Arnel A. Borja a écrit :
> > These are the patches then.
>
> Thanks for these patches.

Thanks Arnel for fixing this.

> > I also updated the .vapi for the changes in
> > the project property interface, though other changes are also included
> > (shouldn't we add some targets in the makefiles for updating this if
> > Anjuta-3.0.gir is modified and vapigen is available in the system?).
> >
> > By the way, this is how I updated the Vala API files:
> > vapigen --pkg gtk+-3.0 --girdir ../../libanjuta --library libanjuta
> > ../../libanjuta/Anjuta-3.0.gir
> > vapigen --pkg gtk+-3.0 --girdir ../../libanjuta --library
> > libanjuta-interfaces ../../libanjuta/IAnjuta-3.0.gir
> > cat libanjuta.vapi libanjuta-interfaces.vapi > libanjuta-3.0.vapi
> > It's my first time to use vapigen, and I don't know much about Vala; I'm
> > not sure if what I've is correct.

Yes, this is correct.

> I suppose Abderrahim has used different options because there is quite a 
> lots of difference. I think it would be better to generated them 
> automatically too but perhaps there are some issues.

The other changes are mostly either things that really changed, or
things that shouldn't be supported in the first place (the List<void*>
things). The only thing that I'd like to keep is the errordomain things
at the end, this is because I was using a patched version of gobject
introspection to work around a bug there.

> I have planned to keep only the changes related to the project 
> properties but I have just seen that Johannes has already committed your 
> patches. There is one error in the function comment for 
> anjuta_project_node_get_properties and 
> anjuta_project_node_get_properties_info. The first function returns a 
> AnjutaProjectProperties and the second one a 
> AnjutaProjectPropertiesInfo. I will fix it.

Good catch.

> > Note: Feel free to change the git commit messages if you like, I know
> > that they are badly written :)
>
> Well, they don't look particularly bad for me so perhaps I'm writing bad 
> commit messages myself.

I find the commit messages in Anjuta are good. The only thing that is
annoying me is that long messages aren't wrapped, but their quality is
good.

Regards,
Abderrahim