On Sunday, 18 December, 2011 06:46 PM, Sébastien Granjoux wrote:
Hi,
Le 18/12/2011 03:20, Arnel A. Borja a écrit :
These are the patches then.
Thanks for these patches.
I also updated the .vapi for the changes
in
the project property interface, though other changes are also
included
(shouldn't we add some targets in the makefiles for updating
this if
Anjuta-3.0.gir is modified and vapigen is available in the
system?).
By the way, this is how I updated the Vala API files:
vapigen --pkg gtk+-3.0 --girdir ../../libanjuta --library
libanjuta
../../libanjuta/Anjuta-3.0.gir
vapigen --pkg gtk+-3.0 --girdir ../../libanjuta --library
libanjuta-interfaces ../../libanjuta/IAnjuta-3.0.gir
cat libanjuta.vapi libanjuta-interfaces.vapi >
libanjuta-3.0.vapi
It's my first time to use vapigen, and I don't know much about
Vala; I'm
not sure if what I've is correct.
I suppose Abderrahim has used different options because there is
quite a lots of difference. I think it would be better to
generated them automatically too but perhaps there are some
issues.
I think it's because it is not updated for a long time. The last
update before mine was this:
commit 7d74eb5828d42177999dc626b6c61ec38730db30
Author: Abderrahim Kitouni <akitouni src gnome org>
Date: Thu Aug 18 10:06:02 2011 +0100
libanjuta, am-project: add an ID string to
AnjutaProjectProperty
It will also be good if we could just include the instructions in
the README file (a bad idea, I think), or in a text file in the doc
directory (just like in GTK+, they have files there for updating
certain parts and instructions on how to make a release).
I have planned to keep only the changes related to the project
properties but I have just seen that Johannes has already
committed your patches. There is one error in the function comment
for anjuta_project_node_get_properties and
anjuta_project_node_get_properties_info. The first function
returns a AnjutaProjectProperties and the second one a
AnjutaProjectPropertiesInfo. I will fix it.
Thanks then! It's my first time to use vapigen.
Note: Feel free to change the git commit
messages if you like, I know
that they are badly written :)
Well, they don't look particularly bad for me so perhaps I'm
writing bad commit messages myself.
I have problems creating the summaries, so I actually copy how your,
and the other's, commit messages are phrased. It'd actually just a
copy-paste of your last commit message, so I'm not confident if they
are good.
Regards,
Sébastien
|
