Re: [xml] Error on including and importing schemas already parsed

[Oblivian <oblivian users sourceforge net>]

Daniel,

From what I've researched on other mailing lists.  The parsing of includes/imports and redefines of namespaces after they've been included/imported or redefined already is allowed by the spec (or at least it doesn't explicitly disallowed it).  Most other parsers allow it, I think libxml2 is about the only one that doesn't.  From the comments in the code I removed it looks like Kasimier was just being careful, but it does remove functionality that is implicitly allowed by the specification.  After further consideration, I don't think that it should impact normal test results and that the patch should be good.  The test case Luke provided should probably be implemented in xstc which I don't have the time to do right now.  If Luke could do it that would be great.

Also,  I would appreciate it if the other code changes could be incorporated for the next release so that I can use imported/included namespaces in a complex schema I have for another project...  the more complex schema you can refer to is at: http://github.com/oblivian/geda-xml/tree/master.

Thanks,
Jason

On Wed, Mar 25, 2009 at 5:36 AM, Daniel Veillard <veillard redhat com> wrote:

On Wed, Mar 04, 2009 at 06:55:42PM -0600, Luke Robison wrote:
> Thank you Jason!  I can also confirm validate_me.xml validates with this
> patch applied, although patching 2.7.3 doesn't work, I had to grab the
> svn version (currently r3819).  Thanks for the help.

 I don't know that part of the code (was done by Kasimier some years
ago), I'm a bit surprized that just removing the check leads to a
correct solution. With or without the patch make check and make tests
in xstc lead to the same results, so I have no way to assert if the
patch introduce regressions.
 If you could give it a bit more testing on different cases and report
I would apply it based on your feedback.

 thanks !

Daniel

--
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/